[Libvir] [PATCH] fix to allow usage of flags when saving XML

Richard W.M. Jones rjones at redhat.com
Thu Jan 24 15:35:43 UTC 2008

Daniel Veillard wrote:
>  As pointed by Jay Gagnon on IRC, virDomainGetXMLDesc() was failing
> if the flags value was non-NULL, and looking at the source we still
> had a check there to fail if flags is non-zero (and we define 2
> flags in virDomainXMLFlags, so this is clearly broken),

+1 for the patch.

We define two flags of interest:

VIR_DOMAIN_XML_SECURE = 1, /* dump security sensitive informations too */
VIR_DOMAIN_XML_INACTIVE = 2/* dump inactive domain informations */

Of these only 'SECURE' is actually used.  I'm not quite sure what the 
second one means, since to dump an inactive domain you'd just call 
virDomainGetXMLDesc on the inactive domain (?)

We probably ought to also document these in the API, and add the 
appropriate flags to virsh too.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080124/14ef1694/attachment-0001.bin>

More information about the libvir-list mailing list