[Libvir] [PATCH] Plug test-related leaks

Richard W.M. Jones rjones at redhat.com
Tue Jan 29 15:30:23 UTC 2008


Jim Meyering wrote:
> Once I had a static "virsh" binary, I ran this:
> 
>     cd src && valgrind --leak-check=full ./virsh --connect \
>       test://$PWD/../docs/testnode.xml list
> 
> which exposed some leaks.
> I fixed them like this:
> 
> 	Plug test-related leaks.
> 	* src/test.c (testLoadNetwork): Free forwardDev.
> 	(testLoadDomain): Free ctxt.
> 	(testLoadNetwork): Likewise.
> 	(testOpenFromFile): Likewise.

Can't really argue with this ... ACK.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080129/a2eb72d5/attachment-0001.bin>


More information about the libvir-list mailing list