[Libvir] [PATCH] fix compilation with USE_XEN == 0

Richard W.M. Jones rjones at redhat.com
Thu Jan 31 19:01:04 UTC 2008


Guido Guenther wrote:
> On Thu, Jan 31, 2008 at 04:14:09PM +0100, Jim Meyering wrote:
>> Guido Guenther <agx at sigxcpu.org> wrote:
>>> statstest.c needs to check if USE_XEN > 0, otherwise compilation breaks
>>> on --without-xen builds. Please apply if appropriate. Patch is against
>>> current cvs.
>> Thanks for the report, but your patch didn't make it to the list.
>> That has happened to me when I've included the output
>> of e.g., git format-patch in the message.  Its headers
>> confuse the old version of Mailman that this list is using.
>>
>> If you think something like that happened here, please
>> send me a copy of your original message and I'll look into it.
> Yes, I actually used git. Here it is without the headers:
> 
> diff --git a/tests/statstest.c b/tests/statstest.c
> index 4c19833..6213da8 100644
> --- a/tests/statstest.c
> +++ b/tests/statstest.c
> @@ -12,7 +12,7 @@ static void testQuietError(void *userData ATTRIBUTE_UNUSED, virErrorPtr error AT
>      /* nada */
>  }
>  
> -#ifdef __linux__
> +#if __linux__ && WITH_XEN
>  static int testDevice(const char *path, int expect)
>  {
>      int actual = xenLinuxDomainDeviceID(NULL, 1, path);
> @@ -31,7 +31,7 @@ int
>  main(void)
>  {
>      int ret = 0;
> -#ifdef __linux__
> +#if __linux__ && WITH_XEN
>      /* Some of our tests delibrately test failure cases, so
>       * register a handler to stop error messages cluttering
>       * up display

Looks good to me.

Rich.

-- 
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080131/fd50b4a0/attachment-0001.bin>


More information about the libvir-list mailing list