[libvirt] [Patch] Libvirt & Autobuild

[Daniel P. Berrange]

On Thu, Jul 10, 2008 at 10:20:26AM -0400, Mohammed Morsi wrote:
> Daniel P. Berrange wrote:
> >On Thu, Jul 10, 2008 at 10:10:25AM -0400, Mohammed Morsi wrote:
> >  
> >>Attached is a small fix to get libvirt working w/ autobuild. Autobuild 
> >>attempts to create and test the RPM, which lists the PolicyKit as one of 
> >>the files to be installed, and thus if it is not installed, autobuild 
> >>reports an error and fails. The was to get this file installed is to 
> >>specify --with-polkit to ./autogen which I added to the autobuild.sh 
> >>build script. (also the syntax check errors broke autobuild, but these 
> >>have been fixed according to the latest email on the list). Knock on 
> >>wood, after this libvirt should work w/ autobuild and will be built 
> >>nightly, and I can finish getting oVirt working with it.
> >>    
> >
> >Hmm, this shouldn't impact the RPM spec at all. The 'autogen.shj' call
> >in the autobuild.sh only applies to the non-RPM build. The RPM build
> >is done via 'configure' in the spec file itself. I think there's 
> >something else going wrong you're hitting instead.
> >
> I'm not expert on autotools, but doesnt autogen.sh traditionally take 
> the configure.ac and Makefile.am files and generate the configure script 
> and make rules? While the build process isn't being held up at the 
> configure or make stages, rather the rpmbuild stage, rpmbuild depends on 
> the output of configure / make, which if --with-polkit is not enabled, 
> will result in the PolityKit file not being included in the build and 
> thus an error when rpm sees it listed under the files in the spec but 
> not the actual file itself. Feel free to correct me if I'm wrong.

autogen.sh creates a generic configure script. The args to configure
only apply to that particular source dir's build - they don't get
propagated through to the RPM spec

This is the sequence:

  autogen.sh
  configure
  make 
  make dist
  rpmbuild libvirt-*tar.gz
    -> configure
    -> make 
    -> make install


The args to the first call to 'configure', have no impact on the
2nd configure run which is done by rpmbuild

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|