[libvirt] [PATCH] repeat lookup by name in LookupByID

[Evgeniy Sokolov]

Daniel Veillard пишет:
> On Wed, Jul 16, 2008 at 08:10:21PM +0100, Daniel P. Berrange wrote:
>> Yes, the documentation is wrong - all inactive VMs have an ID
>> of -1, and thus lookup-by-ID is nonsensical for inactive VMs. 
>>
>> If any application did make use of this change which falls back to
>> lookup-by-name, then it would only ever work with OpenVZ and not
>> any of the other libvirt drivers, which isn't useful behaviour.
> [...]
>>>   Then the virLookupById description must be updated, I'm not against it,
>>> but we need to be coherent.
>> Indeed, the docs need to be clarified.
> 
>   okay, what about
>    * Try to find a domain based on the hypervisor ID number
>    * Note that this won't work for inactive domains which have an ID of -1,
>    * in that case a lookup based on the Name or UUId need to be done instead.
Ok.
In that case we may disable lookup-by-id in undefine subcommand.
> 
> and then revert that specific part of the patch, as attached. Also 
> I would make a 'make rebuild' in the doc directory and push the doc update
> 
> Daniel
> 
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-disable-lookupbyid-in-undefine.diff
Type: text/x-patch
Size: 665 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080717/c7618b96/attachment-0001.bin>