[libvirt] [PATCH] repeat lookup by name in LookupByID

[Daniel Veillard]

On Thu, Jul 17, 2008 at 10:30:19AM +0100, Daniel P. Berrange wrote:
> On Thu, Jul 17, 2008 at 01:20:59PM +0400, Evgeniy Sokolov wrote:
> > Daniel Veillard ?????:
> > >On Wed, Jul 16, 2008 at 08:10:21PM +0100, Daniel P. Berrange wrote:
> > >>Yes, the documentation is wrong - all inactive VMs have an ID
> > >>of -1, and thus lookup-by-ID is nonsensical for inactive VMs. 
> > >>
> > >>If any application did make use of this change which falls back to
> > >>lookup-by-name, then it would only ever work with OpenVZ and not
> > >>any of the other libvirt drivers, which isn't useful behaviour.
> > >[...]
> > >>>  Then the virLookupById description must be updated, I'm not against it,
> > >>>but we need to be coherent.
> > >>Indeed, the docs need to be clarified.
> > >
> > >  okay, what about
> > >   * Try to find a domain based on the hypervisor ID number
> > >   * Note that this won't work for inactive domains which have an ID of -1,
> > >   * in that case a lookup based on the Name or UUId need to be done 
> > >   instead.
> > Ok.
> > In that case we may disable lookup-by-id in undefine subcommand.
> 
> Ahhhh, so that's why you were seeing the error. Yes, this makes sens
> because a VM has to be shutoff before undefine is allowed.

  Okay, understood now :-)

  Applied and commited !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/