[libvirt] [PATCH] qemudDomainCreate: also check uuid
Charles Duffy
Charles_Duffy at messageone.com
Wed Jul 30 18:49:50 UTC 2008
Daniel Veillard wrote:
> Are you disagreeing with the message (which your patch doesn't fix)
> or with the semantic of the check (and then why allow to create a domain
> reusing the UUID of another defined but not running domain, I can only
> see confusion or security problems in doing so)
The act of creating a domain reusing the UUID of another defined but not
running domain is presumably an action taken with intent to rename that
other domain (and thus should undefine the prior domain holding that
UUID in the process... which, admittedly, the given patch didn't
explicitly do).
Anyhow, two patches attached; one revises the error messages, while the
other improves behavior with the semantics I assumed, to explicitly
undefine any duplicates found during a create; I'm happy with either.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-qemu-domain-must-be-active-to-fail-create-r2.patch
Type: text/x-diff
Size: 2137 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080730/94594454/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-qemu-domain-dup-fix-error-message.patch
Type: text/x-diff
Size: 1061 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080730/94594454/attachment-0003.bin>
More information about the libvir-list
mailing list