[libvirt] [PATCH 5/5]: Rewrite findLuns function
Daniel Veillard
veillard at redhat.com
Tue Jun 17 12:34:35 UTC 2008
On Tue, Jun 17, 2008 at 01:02:30PM +0200, Chris Lalancette wrote:
> Reposting the 5/5 patch with Jim's minor comments fixed up. Compile tested only
> with his changes.
>
> This rather large patch rewrites the virStorageBackendISCSIFindLUNs() function
> to only rely on sysfs for finding LUNs, given a session number. Along the way,
> it also fixes the bug where we wouldn't find LUNs for older kernels (with the
> block:sda format), and also (possibly) fixes a race condition where we could try
> to find the LUN before udev has finished connecting it. I say it "possibly"
> fixes it because I haven't been able to hit it so far, but I definitely need
> more testing to try and confirm.
I guess it got sufficient review and feedback, +1
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard at redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
More information about the libvir-list
mailing list