[libvirt] [PATCH]: Fix allocation of tapfds when starting qemu

Chris Lalancette clalance at redhat.com
Thu Jun 19 10:06:28 UTC 2008

     When doing the conversion to danpb's new memory API, a small bug was
introduced into the qemudNetworkIfaceConnect() function.  In particular, there
is a call:

    if (VIR_ALLOC_N(vm->tapfds, vm->ntapfds+2) < 0)
        goto no_memory;

However, the tapfds structure is used to track *all* of the tap fds, and is
called once for each network that is being attached to the domain.  VIR_ALLOC_N
maps to calloc().  So the first network would work just fine, but if you had
more than one network, subsequent calls to this function would blow away the
stored fd's that were already there and fill them all in with zeros.  This
causes multiple problems, from the qemu domains not starting properly to
improper cleanup on shutdown.  The attached patch just changes the VIR_ALLOC_N()
to a VIR_REALLOC_N(), and everything is happy again.

Signed-off-by: Chris Lalancette <clalance at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-qemu-tapfds-fix.patch
Type: text/x-patch
Size: 555 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080619/3c0245d7/attachment-0001.bin>

More information about the libvir-list mailing list