[Libvir] [PATCH] Fix capabilities xml for topology info

Cole Robinson crobinso at redhat.com
Mon Mar 3 17:29:50 UTC 2008


The patch below fixes the capabilities xml generated for the hosts
topology info. This was causing virt-install to barf when using
the test driver (see attached capabilities xml from before this patch).

Thanks,
Cole

diff --git a/src/capabilities.c b/src/capabilities.c
index bedd445..01bb308 100644
--- a/src/capabilities.c
+++ b/src/capabilities.c
@@ -583,7 +583,7 @@ virCapabilitiesFormatXML(virCapsPtr caps)
                                   caps->host.numaCell[i]->ncpus) < 0)
                 goto no_memory;
             for (j = 0 ; j < caps->host.numaCell[i]->ncpus ; j++)
-                if (virBufferVSprintf(&xml, "            <cpu id='%d'>\n",
+                if (virBufferVSprintf(&xml, "            <cpu id='%d'/>\n",
                                       caps->host.numaCell[i]->cpus[j]) < 0)
                     goto no_memory;
             if (virBufferAddLit(&xml, "          </cpus>\n") < 0)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: caps
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080303/2181d4b0/attachment-0001.ksh>


More information about the libvir-list mailing list