[Libvir] PATCH: Don't make connection read-only when non-root

Daniel P. Berrange berrange at redhat.com
Sun Mar 9 21:05:02 UTC 2008

The virsh commands has long forced the connection to be read-only if running
as non-root. This is bogus because it is perfectly capable of authenticating
full read-write connections as non-root since we gained kerberos/policykit
support. The user can always use the explicit --readonly flag if they only
want a read only connection


Index: src/virsh.c
RCS file: /data/cvs/libvirt/src/virsh.c,v
retrieving revision 1.135
diff -r1.135 virsh.c
< #ifndef __MINGW32__
<     /* Force a non-root, Xen connection to readonly */
<     if ((ctl->name == NULL ||
<          !strcasecmp(ctl->name, "xen")) && ctl->uid != 0)
<          ctl->readonly = 1;
< #endif

|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

More information about the libvir-list mailing list