[Libvir] [PATCH] Fix MAC address parsing for 1-digit case

Hiroyuki Kaguchi fj7025cf at aa.jp.fujitsu.com
Wed Mar 19 07:07:34 UTC 2008


Hi, Jim and Rich

Thank you for your suggestions.
I apply the following changes to the patch.
1) Initialize errno to 0 before the loop.
2) Use isxdigit instead of isdigit and isalpha, and add a comment.
3) Test errno != 0.
4) Add a terminating NUL check.
5) the MAC address function go in file src/util.c.

Thanks,

Signed-off-by: Hiroyuki Kaguchi <fj7025cf at aa.jp.fujitsu.com>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: parse_macaddr.patch
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080319/a2379524/attachment-0001.ksh>


More information about the libvir-list mailing list