[Libvir] [RFC] 1 of 4 Linux Container support - base
Dave Leskovec
dlesko at linux.vnet.ibm.com
Thu Mar 20 17:54:03 UTC 2008
Daniel Veillard wrote:
> On Wed, Mar 19, 2008 at 11:14:15PM -0700, Dave Leskovec wrote:
>> This patch adds the base linux container support.
>
> Looks fine to me, with the only suggestion below:
>
>> Index: b/src/virterror.c
>> ===================================================================
>> --- a/src/virterror.c 2008-02-27 02:37:19.000000000 -0800
>> +++ b/src/virterror.c 2008-03-14 10:55:36.000000000 -0700
>> @@ -296,6 +296,9 @@
>> case VIR_FROM_STATS_LINUX:
>> dom = "Linux Stats ";
>> break;
>> + case VIR_FROM_LXC:
>> + dom = "LXC ";
>> + break;
>
> Since we are trying to provide the user with strings for the
> domain of the error, use "Linux Container" instead, it will be
> clearer, even if a bit long,
Yes, that sounds good.
>
> Daniel
>
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
More information about the libvir-list
mailing list