[Libvir] [PATCH] Another Report error in virsh.c code.

[S.Sakamoto]

Hi,

Would you give me a comment on my opinion ?
If not, I make a patch that is suitable for my opinion.


Shigeki Sakamoto.

> >   $ virsh vcpupin
> >   error: command 'vcpupin' requires <domain> option
> >   error: command 'vcpupin' requires <vcpu> option
> >   error: command 'vcpupin' requires <cpulist> option
> These messages that "vshCommandCheckOpts" outputs is no problem.
> 
> What I meant to say was that I want to apply following rules of "migrate" to "vcpupin".
> 
> ***migrate***
>   - when option <desturi> error
>     It outputs error message in "vshCommandCheckOpts".
>       error: command 'migrate' requires <desturi> option
> 
>   - when internal-error occurs at "vshCommandOptString"
>     It outputs error message after "vshCommandOptString".
>       migrate: Missing desturi
> 
> ***vcpupin***
>   - when option <cpulist> error
>     It outputs error message in "vshCommandCheckOpts".
>       error: command 'vcpupin' requires <cpulist> option
> 
>   - when internal-error occurs at "vshCommandOptString"
>     ***no error-message, and return 1***
>     ->I want to output error-message here,
>       because I want to tell an error to a user.
> 
> 
> Regards,
> Shigeki Sakamoto.
> 
> --
> Libvir-list mailing list
> Libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>