[libvirt] Re: [Libvir] [PATCH] lxc: loop in tty forwarding process

[Daniel Veillard]

On Wed, May 07, 2008 at 03:45:46PM +0200, Jim Meyering wrote:
> Daniel Veillard <veillard at redhat.com> wrote:
> > On Tue, May 06, 2008 at 12:51:08AM -0700, Dave Leskovec wrote:
> >   Sounds fine in principle but i have a couple of questions with the patch
> >
> >> +#include <stdbool.h>
> >
> >   err ... what is that ? looks like a linux specific header, do we really
> > need this ? epoll is linux specific I think but  #include <sys/epoll.h>
> > should be sufficient no ?
> 
> <stdbool.h> is not Linux specific.
> It's the C99-specified header that provides e.g,. the "bool" type.
> 
> Good C code has been able to use the "bool" type portably (at least
> through autoconf/gnulib-provided insulation) for many years.
> These days you rarely need the compatibility shims,
> since nearly everyone has a c99-compliant compiler.

  Okay, first time I see it, didn't found it in the standard path,
and the man page about it was looking suspicious to me :-)

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard at redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/