[libvirt] Re: [Libvir] [PATCH] lxc: loop in tty forwarding process
Daniel Veillard
veillard at redhat.com
Thu May 8 07:06:29 UTC 2008
On Wed, May 07, 2008 at 12:47:40PM -0700, Dave Leskovec wrote:
> Daniel Veillard wrote:
> > On Tue, May 06, 2008 at 12:51:08AM -0700, Dave Leskovec wrote:
> [...]
> >> - close(vm->parentTty);
> >> + //close(vm->parentTty);
> >> close(vm->containerTtyFd);
> >
> > if we really don't need this anymore just remove it, if you have doubts then
> > maybe this should be clarified. In any case let's stick to old style comments
> > /* ... */
> >
>
> That shouldn't be commented out. I've restored it in the attached updated patch.
Sounds fine then +1, just push it :-)
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard at redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
More information about the libvir-list
mailing list