[libvirt] Re: [Libvir] [PATCH] sound support for qemu and xen

[Atsushi SAKAI]

Hi, Cole and Dan

I have a question about the reason why it does not support in xen_proxy.
Would you explain why it does not support in xen_proxy?

This policy comes from security issue or other?
If it does already commented on this please show me a pointer.


P.S.
I raise this question when I see the patch of follows.
But I cannot find the reason.
Disable sound functions when in proxy
http://git.et.redhat.com/?p=libvirt.git;a=commit;h=0f7619f25e7dd03296c95241c1de06953ac110c3


Thanks
Atsushi SAKAI



Cole Robinson <crobinso at redhat.com> wrote:

> The patch below adds xml support for the soundhw option to qemu
> and xen. The new xml element takes the form:
> 
> <sound driver='drivername'/>
> 
> Where driver name can be pcspk, sb16, es1370, or all.
> 
> 
> Everything seems to be in working order but I have a few
> implementation questions:
> 
> 1) Should multiple drivers be able to be specified? qemu
> accommodates this, allowing  '-soundhw sb16,pcspk' for example.
> If this should be allowed, what should the xml format be? 
> 
> 2) Should acceptable driver options be hardcoded? The other option
> is to just pass the input straight to qemu. This patch has the
> options hardcoded.
> 
> Also I realize this will probably need to be rediff'd around
> Dan's serial + parallel device patch, but I figured I would just
> get this out there.
> 
> Thanks,
> Cole