[libvirt] PATCH: Don't rely on host binaries in QEMU tests
Jim Meyering
jim at meyering.net
Fri May 16 16:34:14 UTC 2008
"Daniel P. Berrange" <berrange at redhat.com> wrote:
> The QEMU test suites rely on the QEMU/KVM/Xenner binaries being present
> in /usr/bin. This has obvious problems and is unneccessary. The solution
> is to not use the qemudCapsInit() function which initializes capabilities
> based on binaries present. Instead I add a custom impl just for the test
> cases which adds a pre-defined stable set of capabilities. I also had to
> move a stat() check out of qemudBuildCommandLine() and into its caller.
> It probably should have been there in the first place anyway
>
> src/qemu_conf.c | 13 --------
> src/qemu_driver.c | 14 +++++++++
> tests/Makefile.am | 4 +-
> tests/qemuxml2argvtest.c | 4 +-
> tests/qemuxml2xmltest.c | 3 +
> tests/testutilsqemu.c | 71 +++++++++++++++++++++++++++++++++++++++++++++++
> tests/testutilsqemu.h | 5 +++
Looks fine. I confirmed it does fix the test failures.
ACK.
More information about the libvir-list
mailing list