[libvirt] [PATCH] Java bindings for domain events

David Lively dlively at virtualiron.com
Tue Nov 18 18:16:46 UTC 2008

On Mon, 2008-11-17 at 22:22 +0000, Daniel P. Berrange wrote:
> On Mon, Nov 17, 2008 at 03:55:13PM -0500, David Lively wrote:

> Functionally this all looks fine.
> From a style point of view, we should keep consistency with the other
> virEventAddHandle func in terms of typing / param ordering. I prefer
> to have a typedef for the 'freefunc', even though its trivial, because
> I hate reading function prototypes :-) Whether we have the freefunc,
> before or after the 'void opaque' in the register method I don't
> really mind one way or the other as long as we're consistent. Having
> the freefunc last is probably best, since its very often just going
> to be NULL.
> Daniel

Ok, here's a version with "virFreeCallback" as the "freefunc" (now
called "freecb") typedef.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-domain-event-cb-freefunc.patch
Type: text/x-patch
Size: 10812 bytes
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20081118/409f81cd/attachment-0001.bin>

More information about the libvir-list mailing list