[libvirt] --with-xen=foo

[Ben Guthro]

I did a git bisect, and as predicted, the culprit seems to be

aac3e1ab15645f1ff491b140ddb249b01397bebd is first bad commit
commit aac3e1ab15645f1ff491b140ddb249b01397bebd             
Author: Daniel P. Berrange <berrange at redhat.com>            
Date:   Mon Nov 17 10:43:30 2008 +0000                      

    Build drivers as libtool convenience libs


Once again, I am faced with my ignorance of how automake magic works.

It looks to me like XEN_CFLAGS is set properly...but clearly they are not being passed on while compiling stats_linux.c





Ben Guthro wrote on 11/20/2008 09:48 AM:
> So, when I merged my changes up yesterday to some of the developments going on, it would seem that one of the changesets I pulled in had a bit of a reduction in configure flexibility.
> 
> I'm not yet sure what changeset caused it...but I used to be able to specify an external xen tree with the following line in a Makefile...
> 
> ./autogen.sh --prefix=/usr --with-xen=$(XEN_SRC)/dist/install/usr
> 
> This now seems to fail to find that xen tree, as I error out with:
> 
>  gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../gnulib/lib -I../gnulib/lib -I../include -I../include -I../qemud -I/usr/include/libxml2 -DBINDIR=\"/usr/libexec\" -DSBINDIR=\"/usr/sbin\" -DSYSCONF_DIR=\"/etc\" -DLOCALEBASEDIR=\"/usr/share/locale\" -DLOCAL_STATE_DIR=\"/var\" -DGETTEXT_PACKAGE=\"libvirt\" -Wall -Wformat -Wformat-security -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables -g -O2 -MT stats_linux.lo -MD -MP -MF .deps/stats_linux.Tpo -c stats_linux.c  -fPIC -DPIC -o .libs/stats_linux.o
> stats_linux.c:24:16: error: xs.h: No such file or directory
> stats_linux.c: In function 'check_bd_connected':
> stats_linux.c:154: warning: implicit declaration of function 'xs_read'
> stats_linux.c:154: warning: nested extern declaration of 'xs_read'
> stats_linux.c:154: warning: assignment makes pointer from integer without a cast
> 
> 
> I assume this has something to do with Daniel B's changes to configure scripts recently.
> 
> Could you give me a pointer as to where I should be looking?
> 
> Ben
> 
> --
> Libvir-list mailing list
> Libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list