[libvirt] [PATCH 2/2]: Call udevsettle in the appropriate places

Chris Lalancette clalance at redhat.com
Fri Nov 28 14:50:11 UTC 2008

Alan Pevec wrote:
> On Thu, Nov 27, 2008 at 8:53 AM, Chris Lalancette <clalance at redhat.com
> <mailto:clalance at redhat.com>> wrote:
>     Right, both points make sense.  I think the following patch should
>     address it; I
>     only conditionally set the UDEVADM variable if I find it.  So, for
>     machines
>     without it, the meat of virStorageBackendWaitForDevices is compiled
>     out.  In
>     places where I've found it on the build machine, I then do "access" for
>     executable at runtime, and only if that succeeds do I run it.  Does
>     that seem
>     correct?  In addition, based on the comment from Guido, I changed it
>     over to use
>     "udevadm settle" instead of "udevsettle".
> Please make it try both: RHEL5 has an ancient udev095 and doesn't have
> udevadm but it does have udevsettle

Sigh.  Silly older distros :).  Thanks for the heads up, though, good to know it
now rather than later.  Unfortunately, it's not so easy to make it try both; we
would get into a twisty passage of #ifdef's, I think.  Dan, what do you think of
the attached patch for older udev compatibility?

Chris Lalancette
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: libvirt-udevsettle-compat.patch
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20081128/8e706893/attachment-0001.ksh>

More information about the libvir-list mailing list