[libvirt] [PATCH] fix python events

[David Lively]

On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote:
> David Lively <dlively at virtualiron.com> wrote:
> > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote:
> > I'm printing the (user-supplied) object names to help in debugging
> > misbehaving python EventImpls (since there's no static type checking to
> > catch these kinds of things).  So instead of printing "<NULL>" when we
> > can't alloc the name, I'm printing something a little more helpful (the
> > appropriate "generic" name).
> 
> That's better, indeed.
> I prefer your NAME macro, too.
> ACK, modulo syntax:
> 
...

> Reversed diff?  Better to split long lines,
> not to join.

Ok.  Fixed in attached patch.

> > +        <<<
> 
> Trailing white space ^^.

.. along with this one ... and the trailing whitespace on line 1982.

*This* time I ran syntax-check :-)

Dave


 examples/domain-events/events-python/event-test.py |   26 +-
 python/libvir.c                                    |  203 +++++++++++++++++----
 python/libvir.py                                   |    4 
 python/libvirt_wrap.h                              |    8 
 python/types.c                                     |    1 
 python/virConnect.py                               |    4 
 6 files changed, 196 insertions(+), 50 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-python-events.patch
Type: text/x-patch
Size: 16896 bytes
Desc: 
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20081124/a6b4b54f/attachment-0001.bin>