[libvirt] first argument in virDomainMigrate, is it free'ed?

[Daniel P. Berrange]

On Wed, Oct 08, 2008 at 05:08:59PM +0100, Richard W.M. Jones wrote:
> On Mon, Oct 06, 2008 at 06:15:08PM +0200, Stefan de Konink wrote:
> > I saw that freeing the dom after a migration takes place results in:
> > 
> > libvir: Domain error : invalid domain pointer in virDomainFree
> 
> That would be a bug ...
> 
> > Now I wonder, if this is the case, could a normale migrate function
> > 'just' be:
> > 
> > domain = virDomainMigrate(domain, ....)
> > 
> > Or is this unsafe; for example as a domain migration fails?
> 
> virDomainMigrate shouldn't free the source domain ever.  It should be
> up to the caller to free it later once they've ascertained that the
> migration was successful.

I don't see any code which free's the source domain, so I'm not sure
that's the problem.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|