[libvirt] Re: [PATCH/RFC] kvm/qemu vs libvirtd restarts

[Daniel P. Berrange]

On Fri, Oct 10, 2008 at 05:35:04PM +0200, Guido G?nther wrote:
> On Tue, Oct 07, 2008 at 05:37:52PM +0100, Daniel P. Berrange wrote:
> [..snip..] 
> > This also needs to be implemented with the assumption that the daemon
> > can & will crash any time. So putting the state-saving hooks into the
> > qemudShutdown() method won't be sufficient. We need to write out the
> > state we need when initially starting the VM, and then update it any
> > time we hot-plug/unplug devices.
>
> This was actually the first way I looked at this but decided to do it
> the other way around since it saves us from updating the live config all
> the time. But if we consider libvirtd crashable it's indeed better
> to go this way. I'll come up with a different patch, might be a couple
> of days before I get around to it though.

I'd like to think our code was perfect and didn't crash, but experiance
tells me we're not yet perfect ;-) No need to rush - we'll just wait till
you have an updated patch, unles someone has a compelling desire to work
on it right now

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|