[libvirt] [PATCH] avoid many format string warnings

Jim Meyering jim at meyering.net
Mon Oct 13 15:05:40 UTC 2008


"Richard W.M. Jones" <rjones at redhat.com> wrote:
> On Mon, Oct 13, 2008 at 02:21:07PM +0200, Jim Meyering wrote:
> [patch]
>
> +1

Thanks for the feedback.

>> And who knows... maybe someone will be
>> motivated to teach this little script how to break+reindent long lines.
>
> Could we just run all the code through indent at regular
> intervals?

That's the goal, and maybe we'll get there some day,
but right now, that'd do a whole lot more than
just splitting those relatively few lengthened lines.
The problem is that the existing code does not all
conform to the same (or even consistent with a file)
formatting guidelines.

> I was playing with semantic patches the other day - nice idea.
> http://www.emn.fr/x-info/coccinelle/#sp

+1 ;-)




More information about the libvir-list mailing list