[libvirt] [PATCH]: Export the 'label' on block devices
Daniel P. Berrange
berrange at redhat.com
Thu Oct 16 14:41:02 UTC 2008
On Thu, Oct 16, 2008 at 03:47:26PM +0200, Chris Lalancette wrote:
> Daniel P. Berrange wrote:
> >> diff -u -r1.15 storage_backend_fs.c
> >> --- a/src/storage_backend_fs.c 13 Oct 2008 16:46:29 -0000 1.15
> >> +++ b/src/storage_backend_fs.c 16 Oct 2008 12:31:23 -0000
> >> @@ -48,7 +48,8 @@
> >> #include "xml.h"
> >>
> >> enum {
> >> - VIR_STORAGE_POOL_FS_AUTO = 0,
> >> + VIR_STORAGE_POOL_FS_UNKNOWN = 0,
> >> + VIR_STORAGE_POOL_FS_AUTO = 1,
> >
> > This shouldn't be added - automatic is intended to be default.
> >
> >>
> >> enum {
> >> - VIR_STORAGE_VOL_RAW,
> >> + VIR_STORAGE_VOL_UNKNOWN = 0,
> >> + VIR_STORAGE_VOL_RAW = 1,
> >
>
> OK, hopefully last try. Fixed the above two errors and made the disk_type array
> static as suggested by Jim.
>
>
> enum {
> - VIR_STORAGE_POOL_NETFS_AUTO = 0,
> + VIR_STORAGE_POOL_NETFS_UNKNOWN = 0,
> + VIR_STORAGE_POOL_NETFS_AUTO = 1,
> VIR_STORAGE_POOL_NETFS_NFS,
> + VIR_STORAGE_POOL_NETFS_LAST,
> };
I missed that one last time around - no need for "unknown" there. Just
fix that when committing - the rest is fine now.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list