[libvirt] [PATCH] qemu/kvm: allow to hotadd scsi/virtio disks

Guido Günther agx at sigxcpu.org
Fri Oct 17 10:41:14 UTC 2008

On Fri, Oct 17, 2008 at 11:05:50AM +0100, Daniel P. Berrange wrote:
> On Fri, Oct 17, 2008 at 09:48:58AM +0200, Guido G?nther wrote:
> > Hi,
> > recent kvm allows to hot add scsi/virtio disks, it uses pci hotplugging
> > for that. Attached patch adds support for this to libvirt.
> Great, I didn't know SCSI allowed hotplug in QEMU.
Even NICs are hot pluggable now. And since qemu prints a reasonable OK
message we can parse the PCI slot number from the reply which allows for
unplugging as well (delayed that since I'm a bit short on time).

My patch contained a tiny error:
-+    safe_path = qemudEscapeShellArg(dev->data.disk->src);
++    safe_path = qemudEscapeMonitorArg(dev->data.disk->src);

corrected version attached,
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-qemu-add-support-for-virtio-scsi-disk-hotplugging.patch
Type: text/x-diff
Size: 5419 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20081017/d1eb0051/attachment-0001.bin>

More information about the libvir-list mailing list