[libvirt] Re: [PATCH 03/12] Domain Events - daemon changes

[Daniel P. Berrange]

On Tue, Oct 21, 2008 at 03:12:52PM -0400, Ben Guthro wrote:
> [PATCH 03/12] Domain Events - daemon changes
> This code changes the daemaon to:
>   use the pulic def of virEventRegisterImpl
>   Add functionality to dispatch events to connected remote drivers
> 
>  event.c  |   21 +++++----
>  event.h  |    5 +-
>  mdns.c   |   15 ++++--
>  qemud.c  |   72 ++++++++++++++++++++-----------
>  qemud.h  |   11 ++++
>  remote.c |  143 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 227 insertions(+), 40 deletions(-)

> diff --git a/qemud/event.c b/qemud/event.c
> index bb1f381..f391cd1 100644
> --- a/qemud/event.c
> +++ b/qemud/event.c
> @@ -38,7 +38,7 @@
>  /* State for a single file handle being monitored */
>  struct virEventHandle {
>      int fd;
> -    int events;
> +    virEventHandleType events;

As per previous patch, simply using an 'int' is sufficient, likewise
for the few other places in this patch doing the same.

Aside from that, ACK to this patch.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|