[libvirt] [PATCH 2/3]: Log argv passed to virExec and virRun

Cole Robinson crobinso at redhat.com
Thu Oct 30 18:06:20 UTC 2008

The attached patch logs the the argv's passed to
the virExec and virRun functions. There's a bit of
trickery here: since virRun is just a wrapper for
virExec, we don't want the argv string to be logged

I addressed this by renaming virExec to __virExec,
and keeping the original function name to simply
debug the argv and then hand off control. This
means anytime virExec is explictly called, the
argv will be logged, but if functions wish to by
pass that they can just call __virExec (which is
what virRun does.)

Please let me know if there are any problems with
that approach.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-debug-argv.patch
Type: text/x-patch
Size: 2344 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20081030/4177a245/attachment-0001.bin>

More information about the libvir-list mailing list