[libvirt] Committed a fix for building with -Werror

Chris Lalancette clalance at redhat.com
Thu Oct 16 13:43:44 UTC 2008


I just committed this:

+Thu Oct 16 15:41:00 CEST 2008 Chris Lalancette <clalance at redhat.com>
+       * Compiling with -Werror showed a possible use before initialization
+       in src/qemu_driver.c.  Make sure to initialize the olddisk ptr to
+       NULL.
+

Index: src/qemu_driver.c
===================================================================
RCS file: /data/cvs/libvirt/src/qemu_driver.c,v
retrieving revision 1.135
diff -u -r1.135 qemu_driver.c
--- src/qemu_driver.c   13 Oct 2008 16:46:28 -0000      1.135
+++ src/qemu_driver.c   16 Oct 2008 13:42:17 -0000
@@ -2401,6 +2401,7 @@
         return -1;
     }

+    origdisk = NULL;
     newdisk = dev->data.disk;
     for (i = 0 ; i < vm->def->ndisks ; i++) {
         if (vm->def->disks[i]->bus == newdisk->bus &&


-- 
Chris Lalancette




More information about the libvir-list mailing list