[libvirt] Re: [PATCH 01/12] Domain Events - Public API

Daniel Veillard veillard at redhat.com
Wed Oct 22 15:14:12 UTC 2008


On Wed, Oct 22, 2008 at 09:17:28AM -0400, Ben Guthro wrote:
> 
> 
> Daniel Veillard wrote on 10/22/2008 05:14 AM:
> > thanks for the changes! I think the prototypes are good to go, maybe a couple
> > tiny changes but I can make them myself based on the 'make rebuild'
> > output in the doc directory
> > functions in src/libvirt.c still need arguments checkings however, but
> > I can add that later.
> 
> Are these changes worth a 4th round of submissions - or is this something that can be taken care of in a follow-up patch?

  I'm fine with a followup patch, it's not like it's changing anything
significant, I would actually do those once we decided to commit the
whole pack.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/




More information about the libvir-list mailing list