[libvirt] Re: [PATCH 02/12] Domain Events - Internal API

[Daniel P. Berrange]

On Tue, Oct 21, 2008 at 03:11:36PM -0400, Ben Guthro wrote:
> [PATCH 02/12] Domain Events - Internal API
> This patch
>    -Removes EventImpl from being a private function
>    -Introduces the virDomainEventCallbackListPtr, and virDomainEventQueuePtr objects

> diff --git a/src/event.c b/src/event.c
> index 49a9e61..1e2b234 100644
> --- a/src/event.c
> +++ b/src/event.c
> @@ -34,14 +34,15 @@ static virEventAddTimeoutFunc addTimeoutImpl = NULL;
>  static virEventUpdateTimeoutFunc updateTimeoutImpl = NULL;
>  static virEventRemoveTimeoutFunc removeTimeoutImpl = NULL;
>  
> -int virEventAddHandle(int fd, int events, virEventHandleCallback cb, void *opaque) {
> +int virEventAddHandle(int fd, virEventHandleType events,
> +                      virEventHandleCallback cb, void *opaque) {
>      if (!addHandleImpl)
>          return -1;
>  
>      return addHandleImpl(fd, events, cb, opaque);
>  }
>  
> -void virEventUpdateHandle(int fd, int events) {
> +void virEventUpdateHandle(int fd, virEventHandleType events) {
>      updateHandleImpl(fd, events);
>  }

This signature change isn't needed - it should still be just an int,
since we're using the enum as a bitset.

ACK, to the rest of the patch.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|