[libvirt] [PATCH] Fix vnc port determining for xend
veillard at redhat.com
Thu Sep 4 05:51:51 UTC 2008
On Thu, Aug 28, 2008 at 04:48:06PM -0400, Cole Robinson wrote:
> Current libvirt checks xenstore for a xen guests
> fixed vnc port on xend > 3.0.3. At least on f8
> though, hvm guests don't store the vnc port in
> xenstore, it is stored in the sexpr.
> Patch fixes the logic to look in the sexpr if
> the xenstore lookup appears to fail. This fixes
> setting static vnc ports for f8 xen hvm guests.
Sounds fine to me though I winder if it's not better
to check on the given SExpr first and then do a Xenstore
lookup only if needed. Seems to me a more generally coherent
approach, any expected drawback to this ?
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list