[libvirt] PATCH: Only pass in emulator if user requested it
veillard at redhat.com
Thu Sep 4 13:28:30 UTC 2008
On Mon, Sep 01, 2008 at 03:55:57PM +0100, Daniel P. Berrange wrote:
> Previouly with Xen we would only specify an emulator path to XenD if there
> was one provided in the XML. With the new domain XML routines we will always
> lookup the default emulator path internally using our capabilities data.
> So XenD sees an explicit emulator path even if the user didn't request one.
> This works fine, except for paravirt guests where you only want to have
> the text console active, and not the graphical framebuffer. In this
> scenario, XenD starts QEMU-DM to handle the text console, but it crashes
> because PVFB isn't configured.
> This patch switches us back to the old behaviour where we only pass an
> emulator to XenD if the user actually specified one - XenD is intelligent
> enough to auto-configure a QEMU instance for paravirt framebuffers as
> The logic looking up the default emulator did live in the generic XML
> parsing routines. This patch removes it from the XML parsing stage,
> and pushes it down into the individual drivers at time of use (if they
> so desire).
A bit sad to move this out of the completely generic handling, but
considering the complexity, fine, the code is still mostly shared it
seems so it's not such a big deal.
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list