[libvirt] [PATCH] Wrong comments

Anton Protopopov aspsk2 at gmail.com
Mon Sep 15 14:36:31 UTC 2008


In comments to structure 'virDomainInfo' there was reference to smth of type
'virDomainFlags'. Actually, the type of this field must be 'virDomainState'.
Patch includes another one such replacement.

There is another place where 'virDomainFlags' mentioned:
src/xend_internal.c. I think, that argument must be of type
but it is marked as ATTRIBUTE_UNUSED, so I leave the comment as it is :)

And why are you writing
    unsigned char state;
instead of
    virDomainState state;

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080915/94b1ba20/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-wrong-comments.diff
Type: application/octet-stream
Size: 1207 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20080915/94b1ba20/attachment-0001.obj>

More information about the libvir-list mailing list