[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[libvirt] [PATCH] Fix segfault if no qemu emulator passed
- From: Cole Robinson <crobinso redhat com>
- To: libvir-list redhat com
- Subject: [libvirt] [PATCH] Fix segfault if no qemu emulator passed
- Date: Mon, 08 Sep 2008 23:10:17 -0400
There is unfortunately a pretty prevalent
segfault in the latest libvirt. If a qemu
domain is defined without an emulator
specified, libvirtd crashes.
This is doubly unfortunate since current
virtinst generates an emulator-less config
for all qemu and kvm guests (I'm about to fix
this upstream though).
Attached patch fixes this.
Thanks,
Cole
diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index d742c32..23ef050 100644
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
@@ -790,7 +790,7 @@ int qemudBuildCommandLine(virConnectPtr conn,
if (!emulator)
return -1;
- ADD_ARG_LIT(vm->def->emulator);
+ ADD_ARG_LIT(emulator);
ADD_ARG_LIT("-S");
ADD_ARG_LIT("-M");
ADD_ARG_LIT(vm->def->os.machine);
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]