[libvirt] [PATCH] Fix segfault if no qemu emulator passed

[Daniel Veillard]

On Tue, Sep 09, 2008 at 10:24:51AM -0400, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Mon, Sep 08, 2008 at 11:10:17PM -0400, Cole Robinson wrote:
> >> There is unfortunately a pretty prevalent
> >> segfault in the latest libvirt. If a qemu
> >> domain is defined without an emulator
> >> specified, libvirtd crashes.
> >>
> >> This is doubly unfortunate since current
> >> virtinst generates an emulator-less config
> >> for all qemu and kvm guests (I'm about to fix
> >> this upstream though).
> > 
> > #%(*&#@(%@. Damn. This is worthy of a brown paper bag release for libvirt
> > to fix this shockingly bad bug.
> > 
> 
> If we are going to do this I'd really like to get the
> 2 pending max vcpu patches committed, since it's a
> big issue that we largely disallow smp kvm guests
> at this moment.

  Do you need more reviews ? I didn't realized we had pending unapplied
patches ... Repost if necessary, thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/