[libvirt] respect debug level for domain log file

Guido Günther agx at sigxcpu.org
Thu Apr 16 13:38:40 UTC 2009

On Thu, Apr 16, 2009 at 01:29:08PM +0100, Daniel P. Berrange wrote:
> On Thu, Apr 16, 2009 at 02:17:29PM +0200, Guido G?nther wrote:
> > Hi,
> > currently every monitor command is dumped into the domain logfiles, this
> > can lead to huge logs[1]. Since we're not going through the normal
> > logging facilites to get per domain logfiles we should at least resepct
> > the default priority.
> IMHO this should just be removed. We already have ability to log all
> monitor commands via the normal logging mechanism, so we no longer have a
> need to write them out to the domain logs. We should leave the domain logs
> just for QEMU's stdout/err as we originally had them. 
I'm all for it since this makes reparsing the log output safer too.

Attached patch remove the monitor output from the domain log file. To
compensate it prefixes the debug replies with the vm name so it's easier
to find out what's wrong on a crowded system.
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-don-t-log-monitor-command-output-into-domain-log-fil.patch
Type: text/x-diff
Size: 8143 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20090416/62fa0e4f/attachment-0001.bin>

More information about the libvir-list mailing list