[libvirt] [PATCH 0/1] NPIV support

[Dave Allan]

Daniel P. Berrange wrote:
> On Tue, Apr 07, 2009 at 05:16:30PM -0400, David Allan wrote:
>> This patch implements NPIV support.  I don't have easy access to an
>> NPIV capable switch at the moment, so this is all untested code at
>> least from the perspective of whether it actually creates and deletes
>> virtual adapters, but I thought I should get it out to the list for
>> comment sooner rather than later.  I'll have a switch shortly.  If
>> anybody has an NPIV capable test SAN and wants to test it as well, I'd
>> much appreciate the feedback.  
>>
>> Note that libvirt doesn't do any sanity checking of the WWPN/WWNN.  It
>> expects the kernel to verify that the names are valid and the calling
>> application to verify that the names are appropriate for the fabric.
>>
>> The XML to create a pool and create the virtual adapter when the pool
>> is started is:
>>
>> <pool type="scsi">
>>   <name>npiv</name>
>>   <source>
>>     <adapter name="host6" wwpn="0000111122223333" wwnn="4444555566667777"/>
> 
> ACK, this looks good. We should try and arrange it so that when
> resolving this, it matches on wwpn+wwnn as first choice if present,
> and only falls back to adapter name if that fails, since wwpn+wwnn
> offer far better stability

That's a great idea.

>>   </source>
>>   <target>
>>     <path>/dev/disk/by-id</path>
>>   </target>
>> </pool>
>>
>> Stopping the pool deletes the vport.
> 
> I think we need to separate the action sof creating vs starting, and
> stopping vs deleting. The storage pool API in fact already has the
> suport for this separation, via the 'build' and 'delete' commands.

Ok, good to know.  That makes sense.

Dave