[libvirt] UML driver struct refers to public API functions

Daniel P. Berrange berrange at redhat.com
Mon Aug 24 13:13:07 UTC 2009


On Sat, Aug 22, 2009 at 10:04:30PM +0200, Matthias Bolte wrote:
> Hi,
> 
> The commit "Generic shared impls of all NUMA apis"
> (b0b968efd56f6c66bfa23eebbecd491ea993f99b) changed the UML driver
> struct to use the shared NUMA API. But now the UML driver struct
> refers to the public API functions:
> 
> virNodeGetCellsFreeMemory
> virNodeGetFreeMemory
> 
> instead of the shared NUMA API functions
> 
> nodeGetCellsFreeMemory
> nodeGetFreeMemory
> 
> This results in an infinite recursion, if someone's going to call
> virNodeGetCellsFreeMemory with an UML connection.

Opps, that's a bit of a nasty bug. Clearly need to add these APis to
the libvirt-TCK  tests


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list