[libvirt] Re: [PATCH 2/2 v2] add --live support to "virsh dump"

[Daniel P. Berrange]

On Tue, Dec 01, 2009 at 10:19:55AM +0100, Paolo Bonzini wrote:
> This is trivial for QEMU since you just have to not stop the vm before
> starting the dump.  And for Xen, you just pass the flag down to xend.
> 
> * include/libvirt/libvirt.h.in (virDomainCoreDumpFlags): Add
> VIR_DUMP_LIVE.
> * src/qemu/qemu_driver.c (qemudDomainCoreDump): Support live dumping.
> * src/xen/xend_internal.c (xenDaemonDomainCoreDump): Support live dumping.
> * tools/virsh.c (opts_dump): Add --live.
> (cmdDump): Map it to VIR_DUMP_LIVE.
> ---
> 	Since there was consensus, here is the patch with the Xen
> 	driver support.  Applies on top of the --crash patch.


ACK, looks good now

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|