[libvirt] [PATCH] Fix virDomainObj ref handling in QEMU driver

Daniel Veillard veillard at redhat.com
Tue Dec 8 15:23:09 UTC 2009


On Tue, Dec 08, 2009 at 02:46:28PM +0000, Daniel P. Berrange wrote:
> Since the monitor I/O is processed out of band from the main
> thread(s) invoking monitor  commands, the virDomainObj may be
> deleted by the I/O thread. The qemuDomainObjBeginJob takes an
> extra reference to protect against final deletion, but this
> reference is released by the corresponding EndJob call. THus
> after the EndJob call it may not be valid to reference the
> virDomainObj any more. To allow callers to detect this, the
> EndJob call is changed to return the remaining reference count.

  ACK, good idea

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/




More information about the libvir-list mailing list