[libvirt] [PATCH] Fix potential double free in virDomainObjParseXML()
Matthias Bolte
matthias.bolte at googlemail.com
Tue Dec 8 22:49:17 UTC 2009
2009/12/8 Daniel Veillard <veillard at redhat.com>:
> On Sun, Dec 06, 2009 at 11:03:13PM +0100, Matthias Bolte wrote:
>> ---
>> src/conf/domain_conf.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>> index 6a8fd5d..8730f37 100644
>> --- a/src/conf/domain_conf.c
>> +++ b/src/conf/domain_conf.c
>> @@ -3493,6 +3493,7 @@ static virDomainObjPtr virDomainObjParseXML(virConnectPtr conn,
>> error:
>> VIR_FREE(nodes);
>> virDomainChrDefFree(obj->monitor_chr);
>> + obj->monitor_chr = NULL;
>> virDomainObjUnref(obj);
>> return NULL;
>> }
>
> ACK
>
> Daniel
>
This patch is obsolete now, because Daniel Berrange pushed his QEMU
monitor patch series that moved the monitor_chr part to the QEMU
driver.
Matthias
More information about the libvir-list
mailing list