[libvirt] [PATCH 1/3] Tests for ACS in PCIe switches
Mark McLoughlin
markmc at redhat.com
Mon Dec 21 19:39:37 UTC 2009
Hi Jiri,
On Mon, 2009-12-21 at 14:27 +0100, Jiri Denemark wrote:
> @@ -140,6 +141,14 @@ struct _pciDeviceList {
> #define PCI_AF_CAP 0x3 /* Advanced features capabilities */
> #define PCI_AF_CAP_FLR 0x2 /* Function Level Reset */
>
> +#define PCI_EXP_FLAGS 0x2
> +#define PCI_EXP_FLAGS_TYPE 0x00f0
> +#define PCI_EXP_TYPE_DOWNSTREAM 0x6
> +
> +#define PCI_EXT_CAP_ID_ACS 0x000d
> +#define PCI_EXT_ACS_CTRL 0x06
> +#define PCI_EXT_CAP_ACS_ENABLED 0x1d
Just a very minor thing, but it'd be nice if you could reference the
specification and section number etc. in comments like the rest of the
macros do
Thanks,
Mark.
More information about the libvir-list
mailing list