[libvirt] [PATCH] Fix reference leak in remoteDispatchStorageVolCreateXmlFrom

Matthias Bolte matthias.bolte at googlemail.com
Fri Dec 11 01:13:24 UTC 2009


---
 daemon/remote.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/daemon/remote.c b/daemon/remote.c
index 3117615..7a43046 100644
--- a/daemon/remote.c
+++ b/daemon/remote.c
@@ -4118,12 +4118,15 @@ remoteDispatchStorageVolCreateXmlFrom (struct qemud_server *server ATTRIBUTE_UNU
 
     clonevol = get_nonnull_storage_vol (conn, args->clonevol);
     if (clonevol == NULL) {
+        virStoragePoolFree(pool);
         remoteDispatchConnError(rerr, conn);
         return -1;
     }
 
     newvol = virStorageVolCreateXMLFrom (pool, args->xml, clonevol,
                                          args->flags);
+    virStorageVolFree(clonevol);
+    virStoragePoolFree(pool);
     if (newvol == NULL) {
         remoteDispatchConnError(rerr, conn);
         return -1;
-- 
1.6.0.4




More information about the libvir-list mailing list