[libvirt] [PATCH] Allow no <source> for bridge interfaces
John Levon
john.levon at sun.com
Tue Feb 3 15:44:03 UTC 2009
On Tue, Feb 03, 2009 at 02:27:31PM +0000, Daniel P. Berrange wrote:
> > Allow no <source> for bridge interfaces
> >
> > Historically, it was allowed to specify a bridge interface without a
> > specific bridge source, in which case xend would choose one. Keep
> > compatible with this behaviour.
>
> ACK in principle, but this will allow the QEMU, OpenVZ & Xen XM drivers
> to potentially de-reference NULL when using the resulting parsed config
> since they assume that brname is compulsory for type=bridge.
I'll fix them up. Should the first two throw an error back? I'll also
add a comment explaining why we let it through.
regards
john
More information about the libvir-list
mailing list