[libvirt] virGetLastError() disagrees with virConnGetLastError()

[Daniel P. Berrange]

On Tue, Feb 03, 2009 at 11:16:20AM -0500, John Levon wrote:
> On Tue, Feb 03, 2009 at 11:14:24AM +0000, Daniel P. Berrange wrote:
> 
> > I can't reproduce this problem with current CVS.
> > 
> > I made the following change to the 'dump' method in virsh.c
> 
> The difference is I have it /after/ the virDomainFree (actually in
> virCommandRun). I hadn't noticed this before.
> 
> error: Failed to core dump domain Domain-0 to /var/tmp/a
> 0 80a90ac
> 11 POST operation failed: xend_post: error from xen daemon: (xend.err 'Cannot dump core for privileged domain 0')
> virsh: error: POST operation failed: xend_post: error from xen daemon: (xend.err 'Cannot dump core for privileged domain 0')
> 
> Perhaps it's the case that there's no guarantees as to the error state
> after a successful call.

The problem you're hitting is that the last error is only valid until
the next public API call.  virDomainFree is a public API call, so you
can't expect to access the last error, from the virDomainCoreDump
after you call virDomainFree.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|