[libvirt] [PATCH] Fix activeDomainList handling
Jim Meyering
jim at meyering.net
Wed Jan 14 19:19:58 UTC 2009
john.levon at sun.com wrote:
> Fix activeDomainList handling
In your eventual ChangeLog entry, please
mention xsWatchList, too.
> It must be NULLed out after free()ing.
>
> Signed-off-by: John Levon <john.levon at sun.com>
>
> diff --git a/src/xs_internal.c b/src/xs_internal.c
> --- a/src/xs_internal.c
> +++ b/src/xs_internal.c
> @@ -388,8 +388,10 @@ xenStoreClose(virConnectPtr conn)
> }
>
> xenStoreWatchListFree(priv->xsWatchList);
> + priv->xsWatchList = NULL;
> #ifndef PROXY
> xenUnifiedDomainInfoListFree(activeDomainList);
> + activeDomainList = NULL;
> #endif
> if (priv->xshandle == NULL)
> return(-1);
Definitely good fixes.
Otherwise we'd end up dereferencing freed pointers.
However these conflict with Dan's recent changes,
so you should wait to hear from him.
More information about the libvir-list
mailing list