[libvirt] [PATCH] Fix activeDomainList handling

Jim Meyering jim at meyering.net
Wed Jan 14 19:27:36 UTC 2009


John Levon <levon at movementarian.org> wrote:
> On Wed, Jan 14, 2009 at 10:53:51AM -0800, john.levon at sun.com wrote:
>
>> Fix activeDomainList handling
>>
>> It must be NULLed out after free()ing.
>
> This one is incomplete - I didn't find the bug since I have to use
> 0 at 0.so with LIBVIRT_DEBUG. Annoyingly, Solaris printf requires %s
> parameters to not be NULL, and the debug messages use this Linux feature
> in several places... new patch soon

That glibc's printf functions accept a NULL parameter for a %s format
directive is a *mis*feature.  As such, I think any code that relies on
it is buggy, so patches would be most welcome.




More information about the libvir-list mailing list