[libvirt] 5 minor cleanups

Daniel P. Berrange berrange at redhat.com
Mon Jan 5 10:27:25 UTC 2009


On Fri, Dec 26, 2008 at 02:33:57PM +0100, Guido G?nther wrote:
> Hi,
> these accumulated over time. O.k. to apply?

ACK, if you've not already applied this.


> >From f79cfbdaa1cc59dd911f524793324ba7c2cc7096 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Guido=20G=C3=BCnther?= <agx at sigxcpu.org>
> Date: Wed, 24 Dec 2008 00:41:32 +0100
> Subject: [PATCH] ignore TAGS file (created by "make tags")
> 
> ---
>  .gitignore |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index ecb8bf0..de3ba76 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -35,3 +35,4 @@ stamp-h
>  stamp-h.in
>  stamp-h1
>  update.log
> +TAGS
> -- 
> 1.6.0.3
> 

> >From 9bf55bc2f9f42483ebf9a01a4fc99bd53f7a57fa Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Guido=20G=C3=BCnther?= <agx at sigxcpu.org>
> Date: Sun, 23 Nov 2008 16:11:35 +0100
> Subject: [PATCH] remove now bogus comment
> 
> kvmGetMaxVCPUs is now properly implemented
> ---
>  src/qemu_driver.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu_driver.c b/src/qemu_driver.c
> index 9a12b0b..1e86a2a 100644
> --- a/src/qemu_driver.c
> +++ b/src/qemu_driver.c
> @@ -1416,8 +1416,6 @@ static int qemudGetMaxVCPUs(virConnectPtr conn, const char *type) {
>      if (STRCASEEQ(type, "qemu"))
>          return 16;
>  
> -    /* XXX future KVM will support SMP. Need to probe
> -       kernel to figure out KVM module version i guess */
>      if (STRCASEEQ(type, "kvm"))
>          return kvmGetMaxVCPUs();
>  
> -- 
> 1.6.0.3
> 

> >From 35569e95febc37818998cd1834099090a3cf852d Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Guido=20G=C3=BCnther?= <agx at sigxcpu.org>
> Date: Mon, 22 Dec 2008 22:26:03 +0100
> Subject: [PATCH] fix name
> 
> changes AUTHORS file to utf8
> ---
>  AUTHORS |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/AUTHORS b/AUTHORS
> index a8ec325..6cc3a69 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -20,7 +20,7 @@ The primary maintainers and people with commit access rights:
>    Dave Leskovec        <dlesko at linux.vnet.ibm.com>
>    Cole Robinson        <crobinso at redhat.com>
>    Dan Smith            <danms at us.ibm.com>
> -  Guido Guenther       <agx at sigxcpu.org>
> +  Guido Günther        <agx at sigxcpu.org>
>  
>  Patches have also been contributed by:
>  
> -- 
> 1.6.0.3
> 

> >From 84db8d018518d183719b4500b99387869a69b13b Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Guido=20G=C3=BCnther?= <agx at sigxcpu.org>
> Date: Tue, 23 Dec 2008 23:40:14 +0100
> Subject: [PATCH] detach not attach
> 
> ---
>  src/qemu_driver.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/qemu_driver.c b/src/qemu_driver.c
> index 1e86a2a..b38ecd6 100644
> --- a/src/qemu_driver.c
> +++ b/src/qemu_driver.c
> @@ -3364,7 +3364,7 @@ static int qemudDomainDetachDevice(virDomainPtr dom,
>      if (!virDomainIsActive(vm)) {
>          qemuDriverUnlock(driver);
>          qemudReportError(dom->conn, dom, NULL, VIR_ERR_INTERNAL_ERROR,
> -                         "%s", _("cannot attach device on inactive domain"));
> +                         "%s", _("cannot detach device on inactive domain"));
>          goto cleanup;
>      }
>  
> -- 
> 1.6.0.3
> 

> >From 05b1c9750862075f7258a2b8401c580a4cb669e8 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Guido=20G=C3=BCnther?= <agx at sigxcpu.org>
> Date: Wed, 24 Dec 2008 14:54:16 +0100
> Subject: [PATCH] typo
> 
> ---
>  docs/apps.html.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/docs/apps.html.in b/docs/apps.html.in
> index 19736cb..4336271 100644
> --- a/docs/apps.html.in
> +++ b/docs/apps.html.in
> @@ -107,7 +107,7 @@
>      <dl>
>        <dt><a href="http://honk.sigxcpu.org/projects/libvirt/#munin">for munin</a></dt>
>        <dd>
> -	The plugins provided by Guido Günther allows to monitor various things
> +	The plugins provided by Guido Günther allow to monitor various things
>          like network and block I/O with
>          <a href="http://munin.projects.linpro.no/">Munin</a>.
>        </dd>
> -- 
> 1.6.0.3
> 

> --
> Libvir-list mailing list
> Libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list